Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape nested brackets #2001

Merged
merged 2 commits into from
Aug 14, 2024
Merged

fix: escape nested brackets #2001

merged 2 commits into from
Aug 14, 2024

Conversation

yunsii
Copy link
Contributor

@yunsii yunsii commented Aug 13, 2024

Description

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 8:12am

Copy link

github-actions bot commented Aug 13, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.88 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.34%. Comparing base (d6b9698) to head (d9d2b84).
Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2001      +/-   ##
==========================================
- Coverage   76.65%   75.34%   -1.31%     
==========================================
  Files          81       85       +4     
  Lines        2090     2146      +56     
  Branches      533      547      +14     
==========================================
+ Hits         1602     1617      +15     
- Misses        375      415      +40     
- Partials      113      114       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timofei-iatsenko
Copy link
Collaborator

timofei-iatsenko commented Aug 13, 2024

i'm thinking maybe replace regex matching there to the micromatch which should handle this and other cases out of the box? (this is just thinking out loud). I recently revised this code as part of windows compatibility fixes and currently in context of that.

Anyway this looks good to me, meanwhile i will try to implement this using micromatch.

@timofei-iatsenko timofei-iatsenko self-requested a review August 13, 2024 08:28
@andrii-bodnar andrii-bodnar merged commit 6d00301 into lingui:main Aug 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants