Disable eslint in generated message catalog files #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change improves support for non-ejected `create-react-app` apps by effectively disabling eslint in generated build artefacts (`.js` catalog files).
|
@tricoder42 Not sure this is the best implementation, but this works as intended. |
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
======================================
Coverage 91.7% 91.7%
======================================
Files 41 41
Lines 1049 1049
======================================
Hits 962 962
Misses 87 87
Continue to review full report at Codecov.
|
|
Cheers @tricoder42, when is the next planned release? |
|
Soon, today or tomorrow. I'm looking at other issues as well, which we could include in this release. |
|
Released in v2.5.0 |
|
Awesome @tricoder42! Thanks, I'll give it a spin. |
|
Thank you for this. |
|
You’re welcome @lee-reinhardt! |
Photonios
pushed a commit
to SectorLabs/js-lingui
that referenced
this pull request
Dec 9, 2019
* Disable eslint in generated message catalog files This change improves support for non-ejected `create-react-app` apps by effectively disabling eslint in generated build artefacts (`.js` catalog files).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves support for non-ejected
create-react-appapps by effectively disabling eslint in generated build artefacts (.jscatalog files).