-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #271 - give feedback for unrecognized commands #308
fix #271 - give feedback for unrecognized commands #308
Conversation
d524c33
to
78b7755
Compare
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
+ Coverage 91.66% 91.82% +0.15%
==========================================
Files 42 42
Lines 1104 1113 +9
==========================================
+ Hits 1012 1022 +10
+ Misses 92 91 -1
Continue to review full report at Codecov.
|
78b7755
to
f2153d7
Compare
f2153d7
to
3fb55f1
Compare
Realized that I forgot to push up the test file. Will push it up tonight |
@dephiros Yeah, don't worry about it. I honestly don't know why the test fails, but I rerun the test suit and everything is fine. I'm gonna merge it in the morning. Great job, thank you very much! ⚡️ ⚡️ ⚡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I made few changes, but otherwise this PR is good. Thank you for working on this! Really helpful.
- I moved all
console.log
inside utility function, because the output strings usechalk
anyway, so it's used only in console anyway. - Only one command is passed to utility function. I believe it's enough to show the user there's something wrong.
- finally, I renamed the function to
helpMisspelledCommand
because it basically shows a help to user. Similar tohelp
from commander.
fix #271