-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config option for formatOptions - origins - lineNumbers: true / false #805
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I'd also like to keep origins but remove line numbers. In our case the line numbers are incorrect and they don't offer much other than noise in PRs. |
Released right now with 3.8.0! :) |
A question: I tried setting lineNumbers to false which works great for the default (english) translation messages, but doesn't for the second (German) messages.po file? There I get a bunch of "empty" origins (see below). Any ideas how to also get the origins (without line numbers) in the second messages.po file? This is my config
|
@timonbimon: Are you using the latest version of Lingui? This was happening in a previous version but it's working fine for me in the latest |
Thanks updating helped indeed! Sorry for the noise! |
The issue is described in #587
The current state is there is an option in Lingui configuration "origins", which enables / disables including file paths -and- line numbers of origin in the catalog. Origins provide some context information for the translator but at the same time, especially line numbers change regularly. The file part of the origin doesn't change that much and is the part that gives context to translation. My proposal is - if there is some use for keeping line numbers in origins for someone, to add an option to 'origins' - something like 'lineNumbers: true/false" (possibly making false the default). If there isn't really need to keep the line numbers in 'origins', to remove them. What do you think?
The text was updated successfully, but these errors were encountered: