-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fallback cldr #820
feat: fallback cldr #820
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lingui-js/js-lingui/1rzammu69 |
Practically the feature is done,
I think all the cases are covered, I'm a bit tired now so probably something is not correct, I'll take a better look tomorrow |
I'll do some extra testing on a sample project, to check 100% if all the cases are covered and we're ready to |
Codecov Report
@@ Coverage Diff @@
## main #820 +/- ##
==========================================
- Coverage 84.71% 83.87% -0.84%
==========================================
Files 39 39
Lines 1295 1333 +38
Branches 341 356 +15
==========================================
+ Hits 1097 1118 +21
- Misses 117 129 +12
- Partials 81 86 +5
Continue to review full report at Codecov.
|
Tested on create-react-app of examples folder adding ES-MX and ES, translating some things in "es", appears in es-mx 👍🏻 So I think, it works as intended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, great work! Just a few comments bellow, but this is going to be a huge improvement 👍
Looking good! Thanks a lot 👍 |
I am trying to use fallbackLocales and getting error
What is the correct way now to use it? |
Ok, I guess I am reading the latest docs for unreleased version |
@MartinCerny-awin Yes, sorry, there's currently a problem with latest release of docs... It'll be fixed early next week with new release setup |
Will close #791