-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extract multiple comments per translation ID #854
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lingui-js/js-lingui/7iyybj98h |
Remove odd choice where extracted comments where added to translator comments
e336aff
to
83b9e3d
Compare
Codecov Report
@@ Coverage Diff @@
## main #854 +/- ##
==========================================
+ Coverage 83.01% 83.11% +0.09%
==========================================
Files 51 51
Lines 1419 1421 +2
Branches 386 388 +2
==========================================
+ Hits 1178 1181 +3
+ Misses 142 140 -2
- Partials 99 100 +1
Continue to review full report at Codecov.
|
Also fix the implementation Thanks code coverage tool!
Well, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for working on this! 👍
This PR resolves #845
On par file level is collects multiple
extractedComments
(using the same name aspofile
package)This - just like origins - gets merged together to build the catalogue.
Some refactoring was done to use the
extractedComments
name throughout.Possible issues
This change should just work for PO file users.
However if users are using lingui file type thing might break. Namely the
description (string)
is replaced withextractedComments (string[])
. Either some backwards compatibility should be built on top of these changes, or sufficient change information should be provided.What can be improved*
Currently the PO file gets built like with
extractedComments
andreferences
grouped:It would be cool to output them with comment associated with the reference file.
However, it seems that PO file here is major blocker and this change would be way to much work to achieve.