-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parse template strings in t and defineMessage macros #862
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lingui-js/js-lingui/eaicpzyqq |
@@ -36,19 +36,22 @@ export default [ | |||
`, | |||
}, | |||
{ | |||
name: "should left string message intact - template literal", | |||
name: "should transform template literals", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally thiw would be a breaking change, but since the code didn't work as described in documentation, I believe it's just a fix ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope so 🤪
Codecov Report
@@ Coverage Diff @@
## main #862 +/- ##
=======================================
Coverage 83.05% 83.05%
=======================================
Files 51 51
Lines 1422 1422
Branches 390 391 +1
=======================================
Hits 1181 1181
Misses 140 140
Partials 101 101
Continue to review full report at Codecov.
|
Also we should improve the extract plugin so it throws a warning/error when it tries to extract message with |
Closes #861