-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extract accepts files as cli option #881
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lingui-js/js-lingui/d8ikqj5w7 |
Codecov Report
@@ Coverage Diff @@
## main #881 +/- ##
==========================================
+ Coverage 82.76% 82.91% +0.15%
==========================================
Files 51 51
Lines 1427 1440 +13
Branches 392 395 +3
==========================================
+ Hits 1181 1194 +13
Misses 145 145
Partials 101 101
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one minor point, but the code works well.
Co-authored-by: Tomáš Ehrlich <tomas.ehrlich@gmail.com>
Just another awesome feature! Good job! 👍 |
We ship this tomorrow? |
Let's wait a week or so and collect other fixes/features on the way. |
Will close #510
I've adjusted also the help.ts function because when running
yarn extract src/ --verbose
was leading to confusion because params were passed also toyarn compile
command.On create-react-app example of Lingui projects results are really good:
New version with files param:
yarn extract src/ 1.47s user 0.26s system 111% cpu 1.709 total
Actual code branch without files filter:
yarn extract 4.19s user 0.33s system 135% cpu 3.345 total