Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: <Select /> macro not extracted properly #958

Merged
merged 3 commits into from
Jan 26, 2021
Merged

fix: <Select /> macro not extracted properly #958

merged 3 commits into from
Jan 26, 2021

Conversation

semoal
Copy link
Contributor

@semoal semoal commented Jan 26, 2021

#919 Will close this issue

Also will close #959

@vercel
Copy link

vercel bot commented Jan 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/l9jwe6uc2
✅ Preview: https://js-lingui-git-fix-select-macro.lingui-js.now.sh

@github-actions
Copy link

github-actions bot commented Jan 26, 2021

Size Change: 0 B

Total Size: 7.42 kB

ℹ️ View Unchanged
Filename Size Change
./packages/core/build/cjs/core.production.min.js 2.09 kB 0 B
./packages/core/build/cjs/dev.production.min.js 2.09 kB 0 B
./packages/detect-locale/build/cjs/detect-locale.production.min.js 961 B 0 B
./packages/react/build/cjs/react.production.min.js 2.28 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #958 (09a6a17) into main (6b08dd3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #958      +/-   ##
==========================================
+ Coverage   83.50%   83.51%   +0.01%     
==========================================
  Files          53       53              
  Lines        1600     1601       +1     
  Branches      428      428              
==========================================
+ Hits         1336     1337       +1     
  Misses        154      154              
  Partials      110      110              
Impacted Files Coverage Δ
packages/macro/src/macroJsx.ts 91.79% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f73cb8c...09a6a17. Read the comment docs.

@semoal
Copy link
Contributor Author

semoal commented Jan 26, 2021

@MartinCerny-awin

@semoal semoal merged commit 353c537 into main Jan 26, 2021
@semoal semoal deleted the fix-select-macro branch January 26, 2021 19:03
MartinCerny-awin pushed a commit to MartinCerny-awin/js-lingui that referenced this pull request Jan 26, 2021
* chore: fix pseudolocalize tests

* fix: <Select /> choices not extracted

* fix: <Plural /> props on macro not exported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant