Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@lingui/loader): accept webpack 5.x as a peer dependency #971

Merged
merged 1 commit into from
Feb 8, 2021
Merged

fix(@lingui/loader): accept webpack 5.x as a peer dependency #971

merged 1 commit into from
Feb 8, 2021

Conversation

jesec
Copy link
Contributor

@jesec jesec commented Feb 8, 2021

npm 7 mandates matching peer dependencies. See RFC 25.

Fixes "Could not resolve dependency: npm ERR! peer webpack@"^4.0.0" from @lingui/loader"

@lingui/loader works perfectly fine with Webpack 5.x and a medium-size project.

npm 7 mandates matching peer dependencies. See RFC 25.

Fixes "Could not resolve dependency: npm ERR! peer webpack@"^4.0.0" from @lingui/loader"

@lingui/loader works perfectly fine with Webpack 5.x and a medium-size project.
@vercel
Copy link

vercel bot commented Feb 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/8x3phtg5n
✅ Preview: https://js-lingui-git-fork-jesec-main.lingui-js.now.sh

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #971 (041d7f6) into main (a43b71c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #971   +/-   ##
=======================================
  Coverage   83.30%   83.30%           
=======================================
  Files          53       53           
  Lines        1605     1605           
  Branches      430      430           
=======================================
  Hits         1337     1337           
  Misses        156      156           
  Partials      112      112           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a43b71c...041d7f6. Read the comment docs.

@jesec jesec changed the title loader: accept webpack 5.x as a peer dependency chore: accept webpack 5.x as a peer dependency Feb 8, 2021
@semoal semoal changed the title chore: accept webpack 5.x as a peer dependency fix(@lingui/loader): accept webpack 5.x as a peer dependency Feb 8, 2021
@semoal semoal merged commit b9683cc into lingui:main Feb 8, 2021
@semoal
Copy link
Contributor

semoal commented Feb 8, 2021

Great mate, we'll release it as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants