Add Travis build #38
Add Travis build #38
Conversation
Add MSBuild test targets to make the test runner not search for tests within non-test projects as per the following: microsoft/vstest#1129 https://dasmulli.blog/2018/01/20/make-dotnet-test-work-on-solution-files/
|
Looks like this is targeting DotNet core (which is wonderful). Does it still support (and build) the .net Framework version(s)? |
|
@goofballLogic: .NET Core support was added in #37. As |
|
@goofballLogic: Thanks. The redirect check is basically a minimal effort to get the tests to succeed. I agree a less naïve approach should be implemented, but as the primary focus of this PR is to set up continuous integration, automatic testing and code coverage, I feel it's a bit out of scope for what I'm trying to achieve here. That does not mean we shouldn't continue to improve on the code, however. It will only be much easier to do so once this PR is merged since all future pull requests will then be automatically tested by Travis. 😃 |
|
Yes good stuff
…On 10 Jan 2019, 23:05, at 23:05, "Asbjørn Ulsberg" ***@***.***> wrote:
@goofballLogic: Thanks. The redirect check is basically a minimal
effort to get the tests to succeed. I agree a less naïve approach
should be implemented, but as the primary focus of this PR is to set up
continuous integration, automatic testing and code coverage, I feel
it's a bit out of scope for what I'm trying to achieve here. That does
not mean we shouldn't continue to improve on the code, however. It will
only be much easier to do so once this PR is merged since all future
pull requests will then be automatically tested by Travis. 😃
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#38 (comment)
|
This PR adds a Travis CI build, code coverage via Codecov and fixes redirect issues that caused 3 tests to fail.