-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce netstandard version to 1.1 #82
Reduce netstandard version to 1.1 #82
Conversation
I did that as a part of #38, which was about getting the build to pass on Travis. I can't remember exactly why |
yes agreed. I'd like to see legacy frameworks supported when we can too. I think it's very achievable for this library. |
I suppose this is a backwards compatible change so we can release it as a part of the next 1.1 release? |
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
+ Coverage 68.72% 68.74% +0.02%
==========================================
Files 23 23
Lines 4067 4067
Branches 1033 1033
==========================================
+ Hits 2795 2796 +1
+ Misses 1128 1127 -1
Partials 144 144
Continue to review full report at Codecov.
|
edd25fb
to
6add465
Compare
Alright. With that last commit bringing in net40 support, we now have support for every framework and PCL profile that this project has ever supported since birth. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
NOTE: I don't know if this is a good idea or not--I just wanted to kick off the conversation.
I was just experimenting with how low I could get our .NET Standard version.
There are two commits:
netstandard1.1
, andThe first one doesn't appear to have any downsides. The second is probably safe as well. It loses
ICloneable
onContext
, but it looks like it was disabled in all of our builds anyway.Analysis
It turns out that all tests pass with zero changes all the way down to
netstandard1.1
. Unfortunately,netstandard1.0
, is missingHttpClient
. Given thatnetstandard1.0
picks up ZERO additional compatible framework versions, this doesn't seem like a worthwhile tradeoff.netstandard1.1
covers us all the way down to .NET Core 1.0 & .NET Framework 4.5. Best practices recommend targetingnetstandard2.0
as well so that for modern frameworks one doesn't have to restore hundreds of no-op netstandard NuGet packages.@asbjornu, you added
netcoreapp2.1
, a couple of years ago. What does that buy us on top ofnetstandard1.1;netstandard2.0
?