Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LigerCrossEntropyLoss is not patched for latest transformers models #369

Closed
Tcc0403 opened this issue Nov 8, 2024 · 1 comment
Closed

Comments

@Tcc0403
Copy link
Collaborator

Tcc0403 commented Nov 8, 2024

🐛 Describe the bug

To fix GA bug, latest transformers no longer imports CrossEntropyLoss. Instead, it's wrapped in self.loss_function which can be traced back to here. So that current patching method doesn't work on latest transformers model.

Note that labels and logits shifting operations are wrapped in loss_function as well, we need to take care of it when implementing new patching method.

Reproduce

No response

Versions

none

@ByronHsu
Copy link
Collaborator

fixed by #375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants