Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison helpers should still execute when their key parameter is set ... #105

Merged
merged 2 commits into from
Nov 20, 2014

Conversation

sethkinast
Copy link
Contributor

...but resolves to undefined.

Previously, if a helper's key parameter was set, but the Dust variable to which it pointed did not exist, the helper would immediately abort. However, this breaks cases especially for {@ne} in which it would be completely valid if the key did not exist.

The helper will still fail to execute if a key parameter is not passed. However, if the parameter resolves to an undefined variable, it will now execute.

This is a non-backwards-compatible change. Closes #59.

@smfoote
Copy link
Contributor

smfoote commented Nov 18, 2014

L(great)TM

…et but resolves to undefined.

Previously, if a helper's key parameter was set, but the Dust variable to which it pointed did not exist, the helper would immediately abort. However, this breaks cases especially for {@ne} in which it would be completely valid if the key did not exist.

The helper will still fail to execute if a key parameter is not passed. However, if the parameter resolves to an undefined variable, it will now execute.

This is a non-backwards-compatible change. Closes LinkedInAttic#59.
@sethkinast
Copy link
Contributor Author

Added an extra test for key and value both being undefined as per @kate2753 's comment

prashn64 added a commit that referenced this pull request Nov 20, 2014
Comparison helpers should still execute when their key parameter is set, but it resolves to undefined.
@prashn64 prashn64 merged commit 5b39fcc into LinkedInAttic:master Nov 20, 2014
@sethkinast sethkinast deleted the eq-key-undef branch December 11, 2014 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparison filters (@eq, @ne, etc.) should accept undefined as a key.
3 participants