Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

percentile threshold not working #34

Open
lseffer opened this issue Oct 17, 2017 · 0 comments
Open

percentile threshold not working #34

lseffer opened this issue Oct 17, 2017 · 0 comments

Comments

@lseffer
Copy link

lseffer commented Oct 17, 2017

Looks like self.threshold is assigned already in constructor. The percentile part needs rework into if-else or rework.

As it is now, threshold based on percentile is never assigned and instead default threshold value is used (or if specified by parameter score_threshold

https://github.com/linkedin/luminol/blob/master/src/luminol/anomaly_detector.py#L115
https://github.com/linkedin/luminol/blob/master/src/luminol/anomaly_detector.py#L53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lseffer