Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First-Class Support for Argo Rollouts in Linkerd Viz #11489

Closed
Laakso opened this issue Oct 16, 2023 · 3 comments
Closed

First-Class Support for Argo Rollouts in Linkerd Viz #11489

Laakso opened this issue Oct 16, 2023 · 3 comments

Comments

@Laakso
Copy link

Laakso commented Oct 16, 2023

What problem are you trying to solve?

My challenge comes down to how Linkerd handles Argo Rollouts. Currently, Linkerd doesn’t treat Argo Rollouts as a distinct entity; it just considers them as part of the broader ReplicaSets category. When I look at my rollouts in Linkerd Viz, it doesn’t give me a dedicated, clear-cut view. Instead, what bugs me is that it lists all the old ReplicaSets (now inactive and greyed out) from past rollouts right alongside my active ones. It clutters the view and distracts from what’s important: understanding my active rollouts.

How should the problem be solved?

I believe what we need is for Linkerd Viz to recognize and support Argo Rollouts as a first-class citizen. This means:

Identifying Argo Rollout objects specifically, giving them their own space apart from the regular ReplicaSets.

Any alternatives you've considered?

I've been using a ReplicaSet view

How would users interact with this feature?

In Linkerd Viz, I’m picturing a separate section for Argo Rollouts, distinct from other services or entities.
For those of us using the command line, a specific command would make life easier, something like:

linkerd viz stat argo-rollouts -n <namespace>

Would you like to work on this feature?

maybe

@kflynn
Copy link
Member

kflynn commented Oct 18, 2023

Thanks @Laakso! If you might be interested in working on this, what support could we give you?

@kflynn
Copy link
Member

kflynn commented Oct 31, 2023

(A further update: this raises some interesting design questions around the Viz UX, and may require getting in touch with some of the Rollouts folks.)

Copy link

stale bot commented Jan 30, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 30, 2024
@stale stale bot closed this as completed Feb 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants