Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the CLI 'installValues' type with Helm 'Values' type #3291

Merged
merged 10 commits into from
Aug 21, 2019
Merged

Merge the CLI 'installValues' type with Helm 'Values' type #3291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
faace34
Rename template-values.go
Aug 16, 2019
1220664
Temp
Aug 16, 2019
63d7df7
Define new constructor of charts.Values type
Aug 16, 2019
05dcfc9
Move all Helm values related code to the pkg/charts package
Aug 16, 2019
58ba4c3
Bump dependency
Aug 19, 2019
f866de2
Use '/' in filepath to remain compatible with VFS requirement
Aug 19, 2019
b871fa6
Add unit test to verify Helm YAML output
Aug 20, 2019
2015192
Alejandro's feedback
Aug 20, 2019
23af82d
Add unit test for Helm YAML validation (HA)
Aug 20, 2019
c837f23
Remove redundant test fixture
Aug 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile-proxy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ RUN (proxy=$(bin/fetch-proxy $(cat proxy-version)) && \
mv "$proxy" linkerd2-proxy)

## compile proxy-identity agent
FROM gcr.io/linkerd-io/go-deps:c7fb42bd as golang
FROM gcr.io/linkerd-io/go-deps:773dfbc7 as golang
WORKDIR /linkerd-build
COPY pkg/flags pkg/flags
COPY pkg/tls pkg/tls
Expand Down
2 changes: 1 addition & 1 deletion charts/linkerd2/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Identity:
GrafanaImage: gcr.io/linkerd-io/grafana

# heartbeat configuration
HeartbeatSchedule: "0 0 * * * "
HeartbeatSchedule: "0 0 * * *"

# prometheus configuration
PrometheusImage: prom/prometheus:v2.11.1
Expand Down
2 changes: 1 addition & 1 deletion cli/Dockerfile-bin
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## compile binaries
FROM gcr.io/linkerd-io/go-deps:c7fb42bd as golang
FROM gcr.io/linkerd-io/go-deps:773dfbc7 as golang
WORKDIR /linkerd-build
COPY cli cli
COPY charts charts
Expand Down
Loading