Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: build package from repository source #25

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Conversation

ratson
Copy link
Contributor

@ratson ratson commented Oct 21, 2024

  • Move nix files to nix/
  • Set nix package src to use repository
  • Set mainProgram instead of main_program
  • Set version to include commit short hash and modified date

@linkfrg linkfrg self-requested a review October 21, 2024 14:36
Copy link
Owner

@linkfrg linkfrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/user/installation.rst

ignis.url = "git+https://github.com/linkfrg/ignis?submodules=1";

I'm a bit confused by this line. Is it possible to fetch submodules in ignis.nix as it is now?

@ratson
Copy link
Contributor Author

ratson commented Oct 25, 2024

Is it possible to fetch submodules in ignis.nix as it is now?

No, the following command gives the error meson.build:31:0: ERROR: Neither a subproject directory nor a gvc.wrap file was found.,

nix build "github:ratson/ignis/a1ea09b19302944cbf7137e89dddc80f58fa3c47"

while the follow command builds without problem,

nix build "git+https://github.com/ratson/ignis?submodules=1&rev=a1ea09b19302944cbf7137e89dddc80f58fa3c47"

@linkfrg linkfrg self-requested a review October 25, 2024 12:45
Copy link
Owner

@linkfrg linkfrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just a little scared by the length of this line in the docs, in ags for example Gvc fetch manually in default.nix.
Anyway, thanks!

Btw you also need to make a PR for the stable branch to update the stable docs. (no need, i did in a94e205)

@linkfrg linkfrg merged commit c3538c9 into linkfrg:main Oct 25, 2024
@linkfrg linkfrg changed the title Build nix package from repository source nix: build package from repository source Oct 25, 2024
@ratson
Copy link
Contributor Author

ratson commented Oct 26, 2024

Hyprland build from the GitHub repository requires the same, so it should be fine.

Here why github: not working for git submodule: NixOS/nix#4423 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants