Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /healthz HTTP endpoint that can be used as a livenessProbe #93

Closed
bakins opened this issue Jul 24, 2018 · 3 comments
Closed

Add /healthz HTTP endpoint that can be used as a livenessProbe #93

bakins opened this issue Jul 24, 2018 · 3 comments

Comments

@bakins
Copy link
Contributor

bakins commented Jul 24, 2018

It'd be good to have an HTTP endpoint that could be used for Kubernetes readiness and liveness probes. It could return 200 OK. We could create the HTTP listener just before the infinite for loop in a goroutine.

I'm happy to do a PR if you think this is a good idea.
@linki
Copy link
Owner

linki commented Jul 24, 2018

@bakins That's a very good idea!

This was referenced Jul 25, 2018
Merged
Merged
@linki
Copy link
Owner

linki commented Aug 3, 2018

This was done in #94

@linki linki closed this as completed Aug 3, 2018
@linki
Copy link
Owner

linki commented Aug 3, 2018

Thanks @bakins 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@linki @bakins