-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for missing Account-related fields #612
Added support for missing Account-related fields #612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every thing is working locally, LGTM.
} | ||
|
||
// InvoiceItem structs reflect a single billable activity associate with an Invoice | ||
type InvoiceItem struct { | ||
Label string `json:"label"` | ||
Type string `json:"type"` | ||
UnitPrice int `json:"unitprice"` | ||
UnitPrice float32 `json:"unit_price"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is technically a breaking change, granted I can't imagine anyone is using it given the JSON tag was previously wrong 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
📝 Description
Added support for the following fields:
Account
Event
Profile
Invoice
InvoiceItem
Ticket
✔️ How to Test
make testunit
make testint