Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for missing Account-related fields #612

Merged

Conversation

ezilber-akamai
Copy link
Contributor

📝 Description

Added support for the following fields:

Account

  • active_promotions

Event

  • message
  • duration

Profile

  • authentication_type
  • verified_phone_number

Invoice

  • tax
  • tax_summary
  • subtotal
  • billing_source

InvoiceItem

  • total
  • unit_price

Ticket

  • closable

✔️ How to Test

make testunit
make testint

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner November 8, 2024 18:50
@ezilber-akamai ezilber-akamai requested review from jriddle-linode and lgarber-akamai and removed request for a team November 8, 2024 18:50
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every thing is working locally, LGTM.

}

// InvoiceItem structs reflect a single billable activity associate with an Invoice
type InvoiceItem struct {
Label string `json:"label"`
Type string `json:"type"`
UnitPrice int `json:"unitprice"`
UnitPrice float32 `json:"unit_price"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically a breaking change, granted I can't imagine anyone is using it given the JSON tag was previously wrong 👍

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@ezilber-akamai ezilber-akamai added improvement for improvements in existing functionality in the changelog. bugfix for any bug fixes in the changelog. labels Nov 12, 2024
@ezilber-akamai ezilber-akamai merged commit 400777a into linode:main Nov 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix for any bug fixes in the changelog. improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants