upcoming: [M3-7978] - RegionSelect disabled option API updates #10373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
changed the title
abailly-akamai
requested review from
dwiley-akamai,
hana-akamai,
cpathipa and
carrillo-erik
and removed request for
a team
|
Coverage Report: ✅ |
packages/manager/src/features/PlacementGroups/PlacementGroupsCreateDrawer.tsx
Show resolved
Hide resolved
hana-akamai
reviewed
Apr 15, 2024
|
@hana-linode sorry I had forgotten the logic behind this. It's only customer tag based. Basically at the time of the region getting limited availability, the admin script looks at if the user has had any resource in said data-center in the last 3 months. If so, user can continue using that region to create resources. What I would recommend is create a new account (can be employee account) in order to have that region disabled |
|
@dwiley-akamai would have to be a PROD account |
Gotcha, thanks for clarifying and updating the PR description |
packages/manager/src/features/PlacementGroups/PlacementGroupsCreateDrawer.tsx
Outdated
Show resolved
Hide resolved
abailly-akamai
requested review from
dwiley-akamai,
hana-akamai and
bnussman-akamai
dwiley-akamai
approved these changes
Apr 17, 2024
hana-akamai
approved these changes
Apr 17, 2024
carrillo-erik
approved these changes
Apr 17, 2024
mjac0bs
pushed a commit
to mjac0bs/manager
that referenced
this pull request
Apr 18, 2024
…e#10373) * save progress * save progress * save progress * Save progress * fix tests * code cleanup * Improve coverage * moar cleanup * Added changeset: RegionSelect disabled option API updates * Address feedback * Address feedback 2 * fix test
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR allows customizing the disabled RegionSelect option. Previously the disabling of a region (and its associated tooltip) we controlled statically, only based on the region capabilities.
With this update, we keep defaulting to the capability based disabling, and allow a custom handler to disable a region based on whatever logic needed. In this case, it is for the
PlacementGroupCreateDrawerto allow disabling a region based on themaximum_pgs_per_customerregion limit.Changes 🔄
handleDisabledRegionprop toRegionSelectunavailablefront end code to take a newdisabledPropsso we can configure custom tooltip messages and dimensions as wellgetOptionDisabledto reflect the newdisabledPropspropPlacementGroupCreateDrawerto pass new option filtering logic based onmaximum_pgs_per_customerPreview 📷
How to test 🧪
Verification steps
ℹ️ Use PROD
Legacy (no regression)
ℹ️ Use ALPHA
New Behavior (test the new
PlacementGroupCreateDrawerbehavior)As an Author I have considered 🤔
Check all that apply