Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-7684] - Incorrect Error Notice in Volume Drawers for Restricted Users #10646

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Jul 4, 2024

Description 📝

To prevent unauthorized access to specific flows and provide clearer guidance, we aim to restrict entry to users without the required permissions. But for these restricted users, error notices in Volume Drawers are currently not tailored to the action: The text 'edit' is incorrectly displayed on Resize Volume drawer and Attach Volume drawer; it should show 'resize' and 'attach' respectively.

Changes 🔄

  • For restricted users:
    • Fixed the incorrect error notices by replacing 'edit' with 'resize' and 'edit' with 'attach' on the respective Volume drawers.

Target release date 🗓️

July 8th, 2024

Preview 📷

Before After
before-resize-volume-drawer after-resize-volume-drawer
before-attach-volume-drawer after-attach-volume-drawer

How to test 🧪

Prerequisites

(How to setup test environment)

  • Log into two accounts side by side:
    • An unrestricted admin user account: full access
    • A restricted user account (use Incognito for this)
      - Start with Read Only for everything

Reproduction steps

  • As restricted user:
    • Go to Volume action drawers as a read-only user, and observe the error notice for each corresponding drawers.

Verification steps

  • After changes, observe error notices in Volume drawers are tailored to the action.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@pmakode-akamai pmakode-akamai requested a review from a team as a code owner July 4, 2024 16:13
@pmakode-akamai pmakode-akamai requested review from dwiley-akamai and hana-akamai and removed request for a team July 4, 2024 16:13
@pmakode-akamai pmakode-akamai self-assigned this Jul 4, 2024
@pmakode-akamai pmakode-akamai added the Volumes Relating to Volumes (aka Block Storage) label Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

Coverage Report:
Base Coverage: 82.23%
Current Coverage: 82.23%

@pmakode-akamai pmakode-akamai added the Restricted User Access Improve UX surrounding restricted access to features label Jul 4, 2024
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More specific/accurate language in error notice for restricted users in Attach Volume & Resize Volume drawers ✅

@pmakode-akamai pmakode-akamai changed the title fix: [M3-7684] - Incorrect Error Notification Notice on Volume Drawers fix: [M3-7684] - Incorrect Error Notice in Volume Drawers for Restricted Users Jul 5, 2024
@pmakode-akamai pmakode-akamai added the Add'tl Approval Needed Waiting on another approval! label Jul 5, 2024
Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed error notices in the Volume drawers

@hana-akamai hana-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jul 5, 2024
@pmakode-akamai pmakode-akamai merged commit 08aa376 into linode:develop Jul 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Restricted User Access Improve UX surrounding restricted access to features Volumes Relating to Volumes (aka Block Storage)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants