-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:[M3-8330] - Improve API flexibility for useToastNotification #10654
Conversation
Coverage Report: ✅ |
@bnussman-akamai Good suggestions - let me know if there's anything else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change makes sense! Confirming the toast status inversion ✅
will take this into consideration when getting to this refactor for the Events V2 epic
)} | ||
{link && <> {link}</>} | ||
</> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWI this isn't going to remain as such when I get to this part of the event refactor. We are going to use event factories to display these messages to it's centralized and consistent.
Description 📝
We need to enhance the API of this hook to increase its flexibility in handling event notifications. For example, we have a new event,
tax_id_invalid
. When this event is successful (indicating the tax ID is invalid), we want to display the error variant and ensure the notification persists. Currently, there's no way to easily inverse the toast variant depending on the event.Changes 🔄
persistFailureMessage
topersist
tax_id_invalid
event which is feature flaggedinvertVariant
property to handle scenarios where a successful negative event should be represented as anerror
variant.Target release date 🗓️
7/22
How to test 🧪
Verification steps
(How to verify changes)
volume_create
:As an Author I have considered 🤔
Check all that apply