Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upcoming: [M3-6700] - Replace one-off hardcoded black and white color values with colorTokens #11165

Merged
merged 3 commits into from
Oct 29, 2024
Merged

upcoming: [M3-6700] - Replace one-off hardcoded black and white color values with colorTokens #11165

merged 3 commits into from
Oct 29, 2024

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Oct 25, 2024 •
edited
Loading

Description 📝

Note

theme.colorTokens.Neutrals.Black is pitch black ("#232326") in design tokens

Changes 🔄

  • Replaced #000 or black with theme.colorTokens.Neutrals.Black ("#232326")
  • Replaced #fff or white with theme.colorTokens.Neutrals.White

Target release date 🗓️

N/A

Preview 📷

  • No visual changes for white color
  • #000 or black is now pitch black ("#232326") as per neutral black design color token

How to test 🧪

Verification steps

  • Ensure everything builds properly

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@pmakode-akamai pmakode-akamai self-assigned this Oct 25, 2024
@pmakode-akamai pmakode-akamai marked this pull request as ready for review October 25, 2024 16:05
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner October 25, 2024 16:05
@pmakode-akamai pmakode-akamai requested review from dwiley-akamai and hkhalil-akamai and removed request for a team October 25, 2024 16:05
@pmakode-akamai pmakode-akamai changed the title upcoming: [M3-6700] - Replace one off hardcoded black and white colors values with colorTokens upcoming: [M3-6700] - Replace one off hardcoded black and white color values with colorTokens Oct 25, 2024
@pmakode-akamai pmakode-akamai added the Design Tokens Laying the groundwork for Design Tokens label Oct 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

Coverage Report: ✅
Base Coverage: 86.98%
Current Coverage: 86.98%

@pmakode-akamai pmakode-akamai changed the title upcoming: [M3-6700] - Replace one off hardcoded black and white color values with colorTokens upcoming: [M3-6700] - Replace one-off hardcoded black and white color values with colorTokens Oct 28, 2024
@mjac0bs mjac0bs mentioned this pull request Oct 28, 2024
Merged
12 tasks
@pmakode-akamai pmakode-akamai added the Add'tl Approval Needed Waiting on another approval! label Oct 28, 2024
jaalah-akamai
jaalah-akamai approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind the structure change we talked about - up to you how you want to handle that in this PR or in a future one.

@jaalah-akamai jaalah-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Oct 28, 2024
@pmakode-akamai pmakode-akamai merged commit 871210c into linode:develop Oct 29, 2024
23 checks passed
@cypress Cypress
Copy link

cypress bot commented Oct 29, 2024 •
edited
Loading

Cloud Manager E2E    Run #6747

Run Properties:  status check passed Passed #6747  •  git commit 871210c704: upcoming: [M3-6700] - Replace one-off hardcoded black and white color values wit...
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6747
Run duration 25m 36s
Commit git commit 871210c704: upcoming: [M3-6700] - Replace one-off hardcoded black and white color values wit...
Committer Purvesh Makode
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 445
View all changes introduced in this branch ↗︎

@jaalah-akamai jaalah-akamai mentioned this pull request Nov 7, 2024
Merged
@pmakode-akamai pmakode-akamai mentioned this pull request Nov 12, 2024
Merged
12 tasks
@hana-akamai hana-akamai mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaalah-akamai jaalah-akamai jaalah-akamai approved these changes

@hkhalil-akamai hkhalil-akamai hkhalil-akamai approved these changes

@dwiley-akamai dwiley-akamai dwiley-akamai approved these changes

Assignees

@pmakode-akamai pmakode-akamai

Labels
Approved Multiple approvals and ready to merge! Design Tokens Laying the groundwork for Design Tokens
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmakode-akamai @dwiley-akamai @hkhalil-akamai @jaalah-akamai