Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-6454] - Show error for PayPal payments #9058

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

carrillo-erik
Copy link
Contributor

@carrillo-erik carrillo-erik commented Apr 26, 2023

Description 📝

Display an error Notice to the user when PayPal fails to launch after clicking the PayPalChip in the AddPaymentMethodDrawer or the PayPalButton in the PaymentDrawer. Previously a pop-up window would flash and the user would be unaware that an error had occurred.

Also, if the BrainTreePayPalButtons fail to load initially, an error ToolTipIcon is shown to the user.

Preview 📷

Before After
Screen Shot 2023-04-27 at 9 11 05 AM Screen Shot 2023-04-27 at 8 30 46 AM
Screen Shot 2023-04-27 at 9 06 38 AM Screen Shot 2023-04-27 at 8 30 25 AM
Screen Shot 2023-04-27 at 9 05 00 AM Screen Shot 2023-04-27 at 8 36 56 AM

How to test 🧪

  1. Navigate to the Billing page on your local environment and click on either the Make A Payment or Add Payment Method buttons.
  2. Click on the PayPal option.
  3. You should see a PayPal modal flash and then the error Notice should be displayed in the appropriate payment drawer.
  4. The BrainTreePayPalButtons sometimes fail to load which would result in an empty space, try reloading the page a few times and if the failure occurs, the error TooltipIcon should appear in their place.

@carrillo-erik carrillo-erik self-assigned this Apr 26, 2023
@cypress
Copy link

cypress bot commented Apr 26, 2023

Passing run #3206 ↗︎

0 151 3 0 Flakiness 0

Details:

fix: [M3-6454] - Show error for PayPal payments
Project: Cloud Manager E2E Commit: f19b883944
Status: Passed Duration: 14:40 💡
Started: Apr 26, 2023 9:24 PM Ended: Apr 26, 2023 9:38 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this and deleting the old PayPal code!

Did we decide that we need to keep the PayPalErrorBoundary?

@jaalah-akamai
Copy link
Contributor

Confirmed
Screen Shot 2023-04-27 at 11 18 10 AM

@jaalah-akamai jaalah-akamai added the Approved Multiple approvals and ready to merge! label Apr 27, 2023
@carrillo-erik
Copy link
Contributor Author

I decided to keep the PayPalErrorBoundary because after pulling the latest code when I returned to the office, this was the only way to propagate the error. Even when debugging with the dev tools, creating an error state in the PayPalChip would not render the error ToolTipIcon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants