From a243d8ccd6d9808fa478c3151bbe18ebe75f2557 Mon Sep 17 00:00:00 2001 From: Banks Nussman Date: Wed, 6 Dec 2023 18:07:40 -0500 Subject: [PATCH 1/5] add lint step for Cloud Manager --- .github/workflows/ci.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f66114fce88..69725a36751 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -58,6 +58,21 @@ jobs: SLACK_ICON_EMOJI: ":package:" MSG_MINIMAL: true + lint-manager: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - uses: actions/setup-node@v3 + with: + node-version: "18.14" + - uses: actions/cache@v3 + with: + path: | + **/node_modules + key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }} + - run: yarn --frozen-lockfile + - run: yarn workspace linode-manager run lint + test-sdk: runs-on: ubuntu-latest needs: build-validation From 7cafe2acaff649ebcefbe5ea3af04b981b767c35 Mon Sep 17 00:00:00 2001 From: Banks Nussman Date: Wed, 6 Dec 2023 18:26:30 -0500 Subject: [PATCH 2/5] don't lint storybook build js and fix eslint error --- packages/manager/.eslintrc.js | 1 + packages/manager/src/components/Tag/Tag.styles.ts | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/manager/.eslintrc.js b/packages/manager/.eslintrc.js index 1aefa4734d9..3c64f9b2c0e 100644 --- a/packages/manager/.eslintrc.js +++ b/packages/manager/.eslintrc.js @@ -20,6 +20,7 @@ module.exports = { ignorePatterns: [ 'node_modules', 'build', + 'storybook-static', '.storybook', 'e2e', 'public', diff --git a/packages/manager/src/components/Tag/Tag.styles.ts b/packages/manager/src/components/Tag/Tag.styles.ts index 3010a22d869..60f73c87ddd 100644 --- a/packages/manager/src/components/Tag/Tag.styles.ts +++ b/packages/manager/src/components/Tag/Tag.styles.ts @@ -17,7 +17,6 @@ export const StyledChip = styled(Chip, { }, borderRadius: 4, color: theme.name === 'light' ? '#3a3f46' : '#fff', - fontWeight: 'normal', maxWidth: 350, padding: '7px 10px', }, From fcf6b84104855eb13177d3ebc2e3cde3ed2859a6 Mon Sep 17 00:00:00 2001 From: Banks Nussman Date: Wed, 6 Dec 2023 18:52:55 -0500 Subject: [PATCH 3/5] try linting all packages --- .github/workflows/ci.yml | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 69725a36751..dd0d6845301 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,6 +9,24 @@ on: pull_request: jobs: + lint: + strategy: + matrix: + package: [linode-manager, \@linode/api-v4, \@linode/validation] + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - uses: actions/setup-node@v3 + with: + node-version: "18.14" + - uses: actions/cache@v3 + with: + path: | + **/node_modules + key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }} + - run: yarn --frozen-lockfile + - run: yarn workspace ${{ matrix.package }} run lint + build-validation: runs-on: ubuntu-latest steps: @@ -58,21 +76,6 @@ jobs: SLACK_ICON_EMOJI: ":package:" MSG_MINIMAL: true - lint-manager: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 - with: - node-version: "18.14" - - uses: actions/cache@v3 - with: - path: | - **/node_modules - key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }} - - run: yarn --frozen-lockfile - - run: yarn workspace linode-manager run lint - test-sdk: runs-on: ubuntu-latest needs: build-validation From 1b540a129cf48e6ba32563b780cb2f9e014c36a6 Mon Sep 17 00:00:00 2001 From: Banks Nussman Date: Wed, 6 Dec 2023 18:55:57 -0500 Subject: [PATCH 4/5] clean up strings --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index dd0d6845301..3ab595b6619 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,7 +12,7 @@ jobs: lint: strategy: matrix: - package: [linode-manager, \@linode/api-v4, \@linode/validation] + package: ['linode-manager', '@linode/api-v4', '@linode/validation'] runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 From eeebf97204018366728ee1c094bebcaf7d969344 Mon Sep 17 00:00:00 2001 From: Banks Nussman Date: Thu, 7 Dec 2023 09:32:36 -0500 Subject: [PATCH 5/5] add changesets --- .../api-v4/.changeset/pr-9973-tech-stories-1701959506143.md | 5 +++++ .../manager/.changeset/pr-9973-tech-stories-1701959520658.md | 5 +++++ .../.changeset/pr-9973-tech-stories-1701959541076.md | 5 +++++ 3 files changed, 15 insertions(+) create mode 100644 packages/api-v4/.changeset/pr-9973-tech-stories-1701959506143.md create mode 100644 packages/manager/.changeset/pr-9973-tech-stories-1701959520658.md create mode 100644 packages/validation/.changeset/pr-9973-tech-stories-1701959541076.md diff --git a/packages/api-v4/.changeset/pr-9973-tech-stories-1701959506143.md b/packages/api-v4/.changeset/pr-9973-tech-stories-1701959506143.md new file mode 100644 index 00000000000..50d57b80fd2 --- /dev/null +++ b/packages/api-v4/.changeset/pr-9973-tech-stories-1701959506143.md @@ -0,0 +1,5 @@ +--- +"@linode/api-v4": Tech Stories +--- + +Add Lint Github Action ([#9973](https://github.com/linode/manager/pull/9973)) diff --git a/packages/manager/.changeset/pr-9973-tech-stories-1701959520658.md b/packages/manager/.changeset/pr-9973-tech-stories-1701959520658.md new file mode 100644 index 00000000000..84c7d915162 --- /dev/null +++ b/packages/manager/.changeset/pr-9973-tech-stories-1701959520658.md @@ -0,0 +1,5 @@ +--- +"@linode/manager": Tech Stories +--- + +Add Lint Github Action ([#9973](https://github.com/linode/manager/pull/9973)) diff --git a/packages/validation/.changeset/pr-9973-tech-stories-1701959541076.md b/packages/validation/.changeset/pr-9973-tech-stories-1701959541076.md new file mode 100644 index 00000000000..55b8344c6cf --- /dev/null +++ b/packages/validation/.changeset/pr-9973-tech-stories-1701959541076.md @@ -0,0 +1,5 @@ +--- +"@linode/validation": Tech Stories +--- + +Add Lint Github Action ([#9973](https://github.com/linode/manager/pull/9973))