Bug in setOption method

[bogdaniy]

When I set some curl params using setOption method and call reset method, some params(set by me) doesn't reloads, because setOption method has not strict check (in_array https://secure.php.net/manual/ru/function.in-array.php#106319) and it goes to defaultParams . Good idea is to make more strict check with in_array strict param or replace it with isset function.

[linslin]

Hey @bogdaniy,

thanks for your response. I understand, Could you add some codes? Expecially your custom option set by setOption($key, $value). Thanks

[bogdaniy]

Code

$curl = new Curl();
var_dump($curl->getOption(CURLOPT_CUSTOMREQUEST));
$curl->setOption(CURLOPT_CUSTOMREQUEST, 'POST');
$curl->reset();
var_dump($curl->getOption(CURLOPT_CUSTOMREQUEST));

Result
bool(false) string(4) "POST"

[vasadibt]

I think the problem is in 'vendor/linslin/yii2-curl/Curl.php' on line 154

Original code:
if (in_array($key, $this->_defaultOptions) && $key !== CURLOPT_WRITEFUNCTION) {

My temporary solution:
if (array_key_exists($key, $this->_defaultOptions) && $key !== CURLOPT_WRITEFUNCTION) {

[linslin]

Thanks m8s