-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to Python3 #3
Comments
I have opened a PR containing the conversion of the Python 2 scripts to Python 3. Please try these patches. |
Note that there is already some work in https://github.com/linux-nfc/neard/commits/mag/python3-ize branch and the mailing lists. |
I did not see that branch, looks like similar to what I submitted. Why didn't you submit a PR for those changes? |
Mark submitted it for review on the mailing list, no point in sending it to two places at the same time. |
Should I close my PR then? I will keep it on my fork... |
You can try to rebase your changes onto the branch and target it like #13 does. |
It is not an easy merge due to differences in formatting. I ran the scripts through The quick eyeball of the conflicts indicate what is on the branch is virtually identical (aside from formatting) to the code in my branch. I will keep my fork for my own work going forward (as we are using |
Convert the Python test scripts to Python3.
The text was updated successfully, but these errors were encountered: