Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Python3 #3

Closed
krzk opened this issue Aug 4, 2021 · 7 comments · Fixed by #25
Closed

Convert to Python3 #3

krzk opened this issue Aug 4, 2021 · 7 comments · Fixed by #25
Assignees
Labels
enhancement New feature or request

Comments

@krzk
Copy link
Collaborator

krzk commented Aug 4, 2021

Convert the Python test scripts to Python3.

@cc-michaelu
Copy link

I have opened a PR containing the conversion of the Python 2 scripts to Python 3. Please try these patches.

@jtojnar
Copy link

jtojnar commented Apr 7, 2022

Note that there is already some work in https://github.com/linux-nfc/neard/commits/mag/python3-ize branch and the mailing lists.

@cc-michaelu
Copy link

Note that there is already some work in https://github.com/linux-nfc/neard/commits/mag/python3-ize branch and the mailing lists.

I did not see that branch, looks like similar to what I submitted. Why didn't you submit a PR for those changes?

@jtojnar
Copy link

jtojnar commented Apr 7, 2022

Mark submitted it for review on the mailing list, no point in sending it to two places at the same time.

@cc-michaelu
Copy link

Should I close my PR then?

I will keep it on my fork...

@jtojnar
Copy link

jtojnar commented Apr 7, 2022

You can try to rebase your changes onto the branch and target it like #13 does.

@cc-michaelu
Copy link

cc-michaelu commented Apr 7, 2022

It is not an easy merge due to differences in formatting. I ran the scripts through black formatter which results in a different format from what is on the python3-ize branch. So I think I will be closing my PR.

The quick eyeball of the conflicts indicate what is on the branch is virtually identical (aside from formatting) to the code in my branch. I will keep my fork for my own work going forward (as we are using neard in our device).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants