Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really needed little changes. #135

Merged
merged 3 commits into from
Oct 4, 2017
Merged

Conversation

sasanj
Copy link

@sasanj sasanj commented Aug 14, 2017

I should thank you for this little big life saver of code. I thought maybe some simple changes, will make it better and not worse, so...

  1. Why not stick to the good old way of defining objects files? So added a simple OBJ=o.
  2. Why would we want to spam our log files every 7 seconds in systemd? Other startup files are much more polite, so I removed the -v flag from the systemd one.
  3. Why not be polite and give the due credits to people whom we shamefully(!) use their code? Especially if somebody wants to condemn the criminal who wrote such a horrible code!
    AND YES, The last one, was a joke.

sasan added 3 commits August 14, 2017 16:12
It spams the syslog every time the daemon is waked up.
added credit for using Kristensson's settings managment library.
@dgraziotin
Copy link
Collaborator

Many thanks for this. And 👍 to the missing credits. Am all for crediting work, just missed out this one.

@dgraziotin dgraziotin merged commit e45a1d7 into linux-on-mac:master Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants