Switch to POSIX implementation of basename #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop calls to basename on a constant string without a path in it ("rping")
Signed-off-by: Nicolas Morey <nmorey@suse.com>
Include libgen.h to use the POSIX version and not the GNU version of basename. Because it is used on readlink from sysfs paths, there is no risk of trailing '/' so they both behave the same way. This fixes issues with the latest musl which removed the GNU implementation of basename. Signed-off-by: Nicolas Morey <nmorey@suse.com>
jgunthorpe
approved these changes
Jun 4, 2024
|
I'm an idiot. Thought it got merged and deleted the branch :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both call basename on non-const string generated by readlink of a sysfs path. The original string never re-used afterward.
So in these cases, both flavours of basename behave exactly the same from the code PoV
This should solve the issue raised in #1467 and #1443