Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 优化保存后关闭提示 #121

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

pengfeixx
Copy link

优化保存后关闭提示

Bug: https://pms.uniontech.com/bug-view-269141.html
Log: 优化保存后关闭提示

优化保存后关闭提示

Bug: https://pms.uniontech.com/bug-view-269141.html
Log: 优化保存后关闭提示
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • save函数中,_dirty被设置为0两次,应该检查是否有必要。
  • page()->borad()可能是一个拼写错误,应该是page()->board()
  • fileHander()可能是一个拼写错误,应该是fileHandler()

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, rb-union

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jeffshuai
Copy link

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@pengfeixx pengfeixx merged commit 697cb23 into linuxdeepin:develop/snipe Dec 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants