Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spices website still serving old versions of Spices via website and settings module download / update #640

Open
smurphos opened this issue May 25, 2020 · 5 comments

Comments

@smurphos
Copy link
Contributor

smurphos commented May 25, 2020

This has been going on for a couple of years now and it's getting old....

Compare the output of wget -d https://cinnamon-spices.linuxmint.com/files/themes/Cinnamox-Rhino.zip which results in downloading the theme as of it's August 2019 update with wget -d https://cinnamon-spices.linuxmint.com/files/themes/Cinnamox-Rhino.zip? which results in downloading the current version of the theme as per it's update yesterday.

The key difference appears to be

Last-Modified: Sun, 04 Aug 2019 19:00:05 GMT
ETag: "a95f2-58f4f330a20f4"

as opposed to

Last-Modified: Sun, 24 May 2020 07:55:05 GMT
ETag: "885c6-5a6602e2d6665"
steve@steve-Cyan:~$ wget -d https://cinnamon-spices.linuxmint.com/files/themes/Cinnamox-Rhino.zip
DEBUG output created by Wget 1.19.4 on linux-gnu.

Reading HSTS entries from /home/steve/.wget-hsts
URI encoding = ‘UTF-8’
Converted file name 'Cinnamox-Rhino.zip' (UTF-8) -> 'Cinnamox-Rhino.zip' (UTF-8)
--2020-05-25 16:48:15--  https://cinnamon-spices.linuxmint.com/files/themes/Cinnamox-Rhino.zip
Resolving cinnamon-spices.linuxmint.com (cinnamon-spices.linuxmint.com)... 192.124.249.14
Caching cinnamon-spices.linuxmint.com => 192.124.249.14
Connecting to cinnamon-spices.linuxmint.com (cinnamon-spices.linuxmint.com)|192.124.249.14|:443... connected.
Created socket 5.
Releasing 0x000055892efa4050 (new refcount 1).
Initiating SSL handshake.
Handshake successful; connected socket 5 to SSL handle 0x000055892efa4140
certificate:
  subject: CN=cinnamon-spices.linuxmint.com,OU=Domain Control Validated
  issuer:  CN=Go Daddy Secure Certificate Authority - G2,OU=http://certs.godaddy.com/repository/,O=GoDaddy.com\\, Inc.,L=Scottsdale,ST=Arizona,C=US
X509 certificate successfully verified and matches host cinnamon-spices.linuxmint.com

---request begin---
GET /files/themes/Cinnamox-Rhino.zip HTTP/1.1
User-Agent: Wget/1.19.4 (linux-gnu)
Accept: */*
Accept-Encoding: identity
Host: cinnamon-spices.linuxmint.com
Connection: Keep-Alive

---request end---
HTTP request sent, awaiting response... 
---response begin---
HTTP/1.1 200 OK
Server: Sucuri/Cloudproxy
Date: Mon, 25 May 2020 15:48:16 GMT
Content-Type: application/zip
Content-Length: 693746
Connection: keep-alive
X-Sucuri-ID: 13014
X-XSS-Protection: 1; mode=block
X-Frame-Options: SAMEORIGIN
X-Content-Type-Options: nosniff
Content-Security-Policy: upgrade-insecure-requests;
Last-Modified: Sun, 04 Aug 2019 19:00:05 GMT
ETag: "a95f2-58f4f330a20f4"
Expires: Thu, 31 Dec 2037 23:55:55 GMT
Cache-Control: max-age=315360000
X-Sucuri-Cache: HIT
Accept-Ranges: bytes

---response end---
200 OK
Registered socket 5 for persistent reuse.
Length: 693746 (677K) [application/zip]
Saving to: ‘Cinnamox-Rhino.zip’

Cinnamox-Rhino.zip  100%[===================>] 677.49K  1.53MB/s    in 0.4s    

2020-05-25 16:48:16 (1.53 MB/s) - ‘Cinnamox-Rhino.zip’ saved [693746/693746]

steve@steve-Cyan:~$ wget -d https://cinnamon-spices.linuxmint.com/files/themes/Cinnamox-Rhino.zip?
DEBUG output created by Wget 1.19.4 on linux-gnu.

Reading HSTS entries from /home/steve/.wget-hsts
URI encoding = ‘UTF-8’
Converted file name 'Cinnamox-Rhino.zip?' (UTF-8) -> 'Cinnamox-Rhino.zip?' (UTF-8)
--2020-05-25 16:49:24--  https://cinnamon-spices.linuxmint.com/files/themes/Cinnamox-Rhino.zip?
Resolving cinnamon-spices.linuxmint.com (cinnamon-spices.linuxmint.com)... 192.124.249.14
Caching cinnamon-spices.linuxmint.com => 192.124.249.14
Connecting to cinnamon-spices.linuxmint.com (cinnamon-spices.linuxmint.com)|192.124.249.14|:443... connected.
Created socket 5.
Releasing 0x0000560cf9657070 (new refcount 1).
Initiating SSL handshake.
Handshake successful; connected socket 5 to SSL handle 0x0000560cf9657160
certificate:
  subject: CN=cinnamon-spices.linuxmint.com,OU=Domain Control Validated
  issuer:  CN=Go Daddy Secure Certificate Authority - G2,OU=http://certs.godaddy.com/repository/,O=GoDaddy.com\\, Inc.,L=Scottsdale,ST=Arizona,C=US
X509 certificate successfully verified and matches host cinnamon-spices.linuxmint.com

---request begin---
GET /files/themes/Cinnamox-Rhino.zip? HTTP/1.1
User-Agent: Wget/1.19.4 (linux-gnu)
Accept: */*
Accept-Encoding: identity
Host: cinnamon-spices.linuxmint.com
Connection: Keep-Alive

---request end---
HTTP request sent, awaiting response... 
---response begin---
HTTP/1.1 200 OK
Server: Sucuri/Cloudproxy
Date: Mon, 25 May 2020 15:49:24 GMT
Content-Type: application/zip
Content-Length: 558534
Connection: keep-alive
X-Sucuri-ID: 13014
X-XSS-Protection: 1; mode=block
X-Frame-Options: SAMEORIGIN
X-Content-Type-Options: nosniff
Content-Security-Policy: upgrade-insecure-requests;
Last-Modified: Sun, 24 May 2020 07:55:05 GMT
ETag: "885c6-5a6602e2d6665"
Expires: Thu, 31 Dec 2037 23:55:55 GMT
Cache-Control: max-age=315360000
X-Sucuri-Cache: MISS
Accept-Ranges: bytes

---response end---
200 OK
Registered socket 5 for persistent reuse.
Length: 558534 (545K) [application/zip]
Saving to: ‘Cinnamox-Rhino.zip?’

Cinnamox-Rhino.zip? 100%[===================>] 545.44K  1.14MB/s    in 0.5s    

2020-05-25 16:49:25 (1.14 MB/s) - ‘Cinnamox-Rhino.zip?’ saved [558534/558534]
@LinuxOnTheDesktop
Copy link

This seems a rather serious problem.

@Bundy01
Copy link
Contributor

Bundy01 commented Oct 24, 2022

Hi,

this problem has been going on for too long. If the modifications on the site are too complicated, why not add a question mark '?' at the end of the spice download link (cinnamon-spice-updater and on the site)?
#580

Regards.

@Bundy01
Copy link
Contributor

Bundy01 commented Nov 8, 2022

@smurphos: Is this issue still relevant?
I'm telling you this because the last PR #732 has no problem.

@Bundy01
Copy link
Contributor

Bundy01 commented Sep 4, 2023

Unfortunately, the problem persists :/

I've seen it with this PR #755.
I thought it would be solved by now.

Please fix it.

@Bundy01
Copy link
Contributor

Bundy01 commented Sep 5, 2023

Hi,
For devs of the https://cinnamon-spices.linuxmint.com website:

Why set such a large cache value Cache-Control: max-age=315360000?

Many sites use a 0 cache.

EDIT: I think you have a problem with the User-Agent.

  • If I change the UA from my browser to Android, BlackBerry, I phone or tablet; it's correct.
  • If I change the UA to Linux, Windows, Chrome OS or Mac; it's incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants