Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
From my very limited testing and reading this change should work but in practice it appears not to.
What I have tried.
curl -X GET https://dummy.url/ocs/v2.php/cloud/user -u "dummy:random-token-0000-bla-bla-bla" -H "OCS-APIRequest: true"
Etc.
To me that is what we should get.
I tried changing the Nextcloud.php and app.json files in Heimdall/app/SupportedApps/Nextcloud/ to include the changes I have made but it did not work. I get
General error connecting with API
I am not sure if that is because I have not done something correct locally or if this just does not work.One other thing is the Password section shows that the first 5 characters of the key is in the App Password box but this happens regardless of me putting in a key or not so is this just a visual thing and intentional?
Can someone please test and check this
Thanks.