Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stac-validate): cache json schema objects to reduce network failures TDE-1212 #1029

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

blacha
Copy link
Member

@blacha blacha commented Jul 17, 2024

Motivation

What does this change aim to achieve?

We are seeing quite a few network related failures when validating JSON schema objects

Modification

Cache JSON schema objects locally when the docker container is built

Why is this change being made? What implications or other considerations are there?

Checklist

If not applicable, provide explanation of why.

  • Tests updated
  • Docs updated
  • Issue linked in Title

@blacha blacha marked this pull request as ready for review July 17, 2024 23:25
@blacha blacha requested review from a team as code owners July 17, 2024 23:25
Copy link
Contributor

@amfage amfage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blacha blacha added this pull request to the merge queue Jul 23, 2024
Merged via the queue into master with commit 0338068 Jul 23, 2024
2 checks passed
@blacha blacha deleted the fix/json-schema-cache branch July 23, 2024 01:09
github-merge-queue bot pushed a commit that referenced this pull request Jul 25, 2024
🤖 I have created a release *beep* *boop*
---


## [4.2.2](v4.2.1...v4.2.2)
(2024-07-23)


### Bug Fixes

* **basemaps:** Fix the output url path which got additional slash.
([#1023](#1023))
([2cca93e](2cca93e))
* **basemaps:** Keep the existing settings when replacing existing
layer. ([#1024](#1024))
([fc736f5](fc736f5))
* **stac-validate:** cache json schema objects to reduce network
failures TDE-1212
([#1029](#1029))
([0338068](0338068))
* validate band information is consistent
([#1017](#1017))
([ec64f65](ec64f65))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants