generated from linz/template-javascript-hello-world
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure file systems with matching roleArns are registered correctly TDE-1268 #1092
Merged
+201
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
changed the title
fix: ensure file systems with matching roleArns are registered correctly
fix: ensure file systems with matching roleArns are registered correctly TDE-1268
Oct 1, 2024
blacha
requested review from
l0b0,
amfage,
MDavidson17,
paulfouquet and
Wentao-Kuang
October 7, 2024 21:14
l0b0
reviewed
Oct 8, 2024
blacha
commented
Oct 14, 2024
paulfouquet
previously approved these changes
Oct 14, 2024
blacha
commented
Oct 14, 2024
l0b0
approved these changes
Oct 15, 2024
paulfouquet
approved these changes
Oct 15, 2024
amfage
approved these changes
Oct 16, 2024
Merged
l0b0
pushed a commit
that referenced
this pull request
Oct 20, 2024
…tly TDE-1268 (#1092) #### Motivation file systems are only created for unique roleArns so FileSystemCreated event is not fired twice if two configuration objects have the same roleArn, give a confiugration with two buckets both using `roleA` on a service that has a default role `roleDefault` ``` s3://foo/ - roleA s3://bar/ - roleA ``` requests to ```typescript fs.read("s3://foo"); // tries roleDefault then uses roleA fs.read("s3://foo"); // uses cached roleA ``` depending on the order of reads the default role may be used far too often ```typescript fs.read("s3://foo") // tries roleDefault then uses roleA fs.read("s3://bar") // tries roleDefault then uses roleA fs.read("s3://bar") // tries roleDefault then uses roleA ``` after this change ```typescript fs.read("s3://foo") // tries roleDefault then uses roleA fs.read("s3://bar") // tries roleDefault then uses roleA fs.read("s3://bar") // uses cached roleA ``` #### Modification hook the file system finder when it needs to find a new file system use that file system to register onto `fsa` #### Checklist _If not applicable, provide explanation of why._ - [ ] Tests updated - [ ] Docs updated - [ ] Issue linked in Title
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
🤖 I have created a release *beep* *boop* --- ## [4.7.0](v4.6.0...v4.7.0) (2024-10-21) ### Features * **basemaps:** Add nz-elevation bucket as valid source s3 bucket. BM-1088 ([#1109](#1109)) ([bc09b74](bc09b74)) * expose method to calculate a sheet code from any x,y ([#1110](#1110)) ([ffa03ad](ffa03ad)) * Flatten providers into strings per role TDE-1291 ([#1108](#1108)) ([92af2f9](92af2f9)) ### Bug Fixes * ensure file systems with matching roleArns are registered correctly TDE-1268 ([#1092](#1092)) ([e004506](e004506)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
file systems are only created for unique roleArns so FileSystemCreated event is not fired twice if two configuration objects have the same roleArn,
give a confiugration with two buckets both using
roleA
on a service that has a default roleroleDefault
requests to
depending on the order of reads the default role may be used far too often
after this change
Modification
hook the file system finder when it needs to find a new file system use that file system to register onto
fsa
Checklist
If not applicable, provide explanation of why.