fix(basemaps): Import config types from the file to avoid importing dynamo #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
approved these changes
Sep 21, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
🤖 I have created a release *beep* *boop* --- ## [2.14.0](v2.13.0...v2.14.0) (2023-09-21) ### Features * **basemaps:** Get the region from collection.json and validate the source and target bucket. ([#662](#662)) ([821225e](821225e)) * **basemaps:** Remove the @basemaps/shared package from argo-tasks. ([#665](#665)) ([71449b8](71449b8)) * **basemaps:** Update the create-pr cli to take targets as input. ([#661](#661)) ([3b1bd1a](3b1bd1a)) * **bmc:** New github wrapper to use github api by pat. BM-878 ([#634](#634)) ([3d6c81e](3d6c81e)) * pretty print JSON files TDE-759 ([#647](#647)) ([1beab94](1beab94)) ### Bug Fixes * **basemaps:** Import config types from the file to avoid importing dynamo ([#666](#666)) ([6574d87](6574d87)) * **stac-sync:** add content type ([#645](#645)) ([a137084](a137084)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Import the types from files directly to stop import dynamo into the bundle file.
Intention
aws-sdk are required when using
@basemaps/sharedpackage. As this is not required, we should not import the whole package into code.Checklist
If not applicable, provide explanation of why.