feat: force fully qualified domains for s3 requests TDE-1084 #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
requested review from
l0b0,
amfage,
MDavidson17,
paulfouquet and
Wentao-Kuang
l0b0
reviewed
Mar 26, 2024
paulfouquet
approved these changes
Mar 26, 2024
l0b0
approved these changes
Mar 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 7, 2024
🤖 I have created a release *beep* *boop* --- ## [3.4.0](v3.3.2...v3.4.0) (2024-04-03) ### Features * **basemaps:** Update the create-pr cli to add new individual vector tileset. BM-992 ([#933](#933)) ([9234ffb](9234ffb)) * detects and error if the tiff is not 8 bits TDE-895 ([#890](#890)) ([9e639b7](9e639b7)) * force fully qualified domains for s3 requests TDE-1084 ([#940](#940)) ([3fdbf98](3fdbf98)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to linz/basemaps
that referenced
this pull request
Apr 18, 2024
… load TDE-1084 (#3223) #### Motivation In our kubernetes cluster we are seeing perodic DNS resolution failures, see linz/argo-tasks#940 for more information #### Modification force FQDN to be used for S3 requests when using cogify #### Question Should, lambda-tiler also use FQDNs ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Inside kubernetes dns resolution uses
ndots: 5this means any dns requests that has less than 5 dots will go through all the search domains before looking up the actual domain. AWS s3 has 4 dots.We are seeing 10-20 DNS requests per s3 DNS request due to the number of search domains as well as IPV6 requests.
Modification
Any DNS requests to S3 are modified to have a trailing "." to force the DNS lookup to be fully qualified.
Checklist
If not applicable, provide explanation of why.