feat: save a copy of capture-area.geojson as an artifact for Argo Workflows TDE-1045 #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
MDavidson17
previously approved these changes
Feb 18, 2024
l0b0
reviewed
Feb 18, 2024
l0b0
approved these changes
Feb 18, 2024
MDavidson17
approved these changes
Feb 19, 2024
paulfouquet
deleted the
feat/save-capture-area-to-local-tmp-dir-tde-1045
branch
Merged
github-merge-queue bot
pushed a commit
to linz/topo-workflows
that referenced
this pull request
Feb 21, 2024
#### Motivation A direct access to the `capture-area.geojson` file from the workflow UI can be useful for the user to verify data. linz/topo-imagery#860 #### Modification Add a workflow artifact containing the local copy of `capture-area.geojson` #### Checklist - [ ] Tests updated N/A - [ ] Docs updated N/A - [x] Issue linked in Title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to allow Argo Workflows UI to expose a file to the user, the file has to be stored in the local machine. The workflows can then pulled the file as an artifact output. linz/topo-workflows#443
Modification
Save a copy of
capture-area.geojsonfile in a different path than the one linked to the STAC Collection.Another option would be to only save the file locally and let Argo Workflow to save it to the target directory. I haven't choose that option to monitor AWS issues from the application rather than from Argo.
Checklist