feat: log capture-area generation duration TDE-1080 #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
reviewed
Mar 4, 2024
l0b0
previously approved these changes
Mar 5, 2024
There was a problem hiding this comment.
LGTM except I agree we should be using trace instead debug.
We should probably standardise function timing separately.
l0b0
previously approved these changes
Mar 5, 2024
MDavidson17
previously approved these changes
Mar 5, 2024
amfage
previously approved these changes
Mar 5, 2024
paulfouquet
dismissed stale reviews from amfage, MDavidson17, and l0b0
via
d836bde
amfage
approved these changes
Mar 6, 2024
l0b0
approved these changes
Mar 6, 2024
paulfouquet
deleted the
feat/log-capture-area-generation-duration-tde-1080
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I want to know when starts and how long takes this process
Modification
Add some logs
Checklist