-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL Detection Problem #82
Comments
Hi @Ricardolcm888 thanks for reporting it. I will think about it, however right now I do not see any general solution for this. |
Yes this is in fact a problem
results in:
@lipoja RE: I had to fix this for my ML pre-processing, pretty straightforward fix, will submit a PR shortly... |
@amoldavsky Thank you for contributing! Sure I can merge it and release it. But before I do that I would like to discuss with you few of my ideas so we do not break extraction or unintentionally filter out some URLs which would be extracted with current code. Please have a look to your PR. |
Yup, I started a discussion in the PR |
facing the same issue, was curious what is the state of PR for fixing this! :) |
I tried to use the module to detect a link in the following string.
but it failed to detect that there is a url.
The text was updated successfully, but these errors were encountered: