Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xlsx export buffers in memory #263

Open
ihucos opened this issue May 16, 2018 · 6 comments
Open

xlsx export buffers in memory #263

ihucos opened this issue May 16, 2018 · 6 comments

Comments

@ihucos
Copy link

ihucos commented May 16, 2018

but it should be streamed

here is the code https://github.com/liqd/adhocracy4/blob/master/adhocracy4/exports/views.py#L19
It should be ok for a while, since we are hosting our own servers we can have plenty of memory per request and its a feature that is not used a lot at once. So this is also a problem where we wait for it come to us before solving it.
Ha but on the other hand since this should be an open source base component we could fix it because in other setups this would not work (more db entries, different hosting)

The easiert solution is probably to buffer it in a file, send the file, then delete it

@ihucos ihucos changed the title xlsx export buffered in memory xlsx export buffers in memory May 16, 2018
@fuzzylogic2000
Copy link
Contributor

Also, this will be the problem with the cut off comments?! Good catch!

@ihucos
Copy link
Author

ihucos commented May 16, 2018

I talked with Robert, in our infrastructure we should not run into any kind of problems since we have plenty of RAM per request. If you mean with cut off comments, that the file is incomplete or that there are comments missing, I don't think that problem would be related to this issue.

@fuzzylogic2000
Copy link
Contributor

:(

@ihucos
Copy link
Author

ihucos commented May 16, 2018

Removing a single line: https://github.com/liqd/adhocracy4/blob/master/adhocracy4/exports/views.py#L27
We would buffer the export in a file, but as talked with @treba123 (Robert) that would also not be so nice.

@fuzzylogic2000
Copy link
Contributor

@goapunk Uh, we already have an issue for this. :)

@goapunk
Copy link
Contributor

goapunk commented Mar 6, 2023

a rather old one ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants