Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump controller-runtime to v0.18.5 and k8s libs to v.1.30.3 #2705

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Aug 23, 2024

Description

This PR bumps k8s to v1.30.3 and controller-runtime to v0.18.5 and adds the following fixes:

  • skip tests using Server Side Apply (SSA) on fake-client (temporary workaround to be revised after fixed upstream)
  • refactor code to support breaking changes introduced in v0.18.x (admission.Decoder is now an interface and WatchRawSource() arguments)

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 added the dependencies Pull requests that update a dependency file label Aug 23, 2024
@fra98 fra98 force-pushed the frt/bump-controller-runtime branch from 8a445a4 to 7051558 Compare August 23, 2024 13:08
@fra98 fra98 requested a review from aleoli August 27, 2024 13:13
@fra98 fra98 force-pushed the frt/bump-controller-runtime branch from 7051558 to 61dae86 Compare August 28, 2024 13:44
@fra98
Copy link
Member Author

fra98 commented Aug 28, 2024

/test

@fra98 fra98 changed the title Bump controller-runtime to v0.18.5 Bump controller-runtime to v0.18.5 and k8s libs to v.1.30.3 Aug 29, 2024
@fra98
Copy link
Member Author

fra98 commented Aug 29, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Aug 29, 2024
@adamjensenbot adamjensenbot merged commit ffa3b66 into liqotech:master Aug 29, 2024
15 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants