Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"timestamp with timezone" column type is converted to plain "timestamp" #11

Closed
tyler-laberge opened this issue Feb 26, 2020 · 0 comments

Comments

@tyler-laberge
Copy link
Contributor

tyler-laberge commented Feb 26, 2020

Specifying a column type of "timestamp with timezone" should create a column in redshift of the type "timestamptz". See supported datatypes

Instead, it looks like this is getting converted to a regular "timestamp" type in DateTimeTypeRedshift.java/TimestampTypeRedshift.java (I'm guessing redshift timezone support did not exist at the time)

I think we just need to remove these custom datatypes and it should work fine. I have tried this on a fork and as expected the column in redshift is given the type "timestamptz".

Created PR #12 with this change

@r2-lf r2-lf closed this as completed in f92d228 Apr 21, 2020
r2-lf added a commit that referenced this issue Apr 21, 2020
Fixes #11 - Removed unnecessary custom timestamp datatypes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant