Skip to content

Latest commit

 

History

History
23 lines (17 loc) · 1.7 KB

DEVELOPER_NOTES.md

File metadata and controls

23 lines (17 loc) · 1.7 KB

Developer Notes

Dropping standard rules

When we upgraded to the latest '@stylistic' plugin and ruleset, we had a couple conflict with the 'standard' ruleset. We thought about dropping the standard rules, but there are a lot of good ones, so instead of losing that work, we deleted the conflicting rules. We may find additional conflicts in the future.

Weird dependency

In order to get the test running, we had to add @babel/plugin-proposal-class-properties and @babel/plugin-proposal-optional-chaining as developer dependencies. Otherwise we would get an error from babel (7.23.0) that it could not load these dependencies. As far as we can tell, the dependency load is coming from within babel and not based on any config of ours.

"Parsing error: Cannot resolve module '@babel/plugin-proposal-optional-chaining' from paths ['/Users/zane/.liq/playground/liquid-labs/catalyst-resource-eslint/dist/babel'] from /Users/zane/.liq/playground/liquid-labs/catalyst-resource-eslint/node_modules/@babel/core/lib/config/files/plugins.js\n" +
          '- Did you mean "@babel/plugin-transform-optional-chaining"?\n' +
          '\n' +
          'Make sure that all the Babel plugins and presets you are using\n' +
          'are defined as dependencies or devDependencies in your package.json\n' +
          "file. It's possible that the missing plugin is loaded by a preset\n" +
          'you are using that forgot to add the plugin to its dependencies: you\n' +
          'can workaround this problem by explicitly adding the missing package\n' +
          'to your top-level package.json.',

This has been captured in issue #2.