Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bot token for image push #127

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Use bot token for image push #127

merged 2 commits into from
Feb 1, 2022

Conversation

Callisto13
Copy link
Member

Closes #96

@Callisto13 Callisto13 added the kind/feature New feature or request label Jan 31, 2022
@Callisto13 Callisto13 requested a review from a team January 31, 2022 16:31
yitsushi
yitsushi reviewed Feb 1, 2022
View reviewed changes
.github/workflows/release.yml Outdated
@@ -21,7 +21,7 @@ jobs:
with:
registry: ghcr.io
username: ${{ secrets.DOCKER_USERNAME }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the same? It's a bit confusing using DOCKER_USERNAME with GHCR_BOT_TOKEN

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly that username is not used at all by ghcr itself, but the action requires it anyway, i could rename it to be FOOBAR with an empty string

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gone for github.actor just for clarity

@Callisto13 Callisto13 merged commit e996e5f into main Feb 1, 2022
@Callisto13 Callisto13 deleted the update-ghcr-token branch February 1, 2022 11:15
Callisto13 added a commit that referenced this pull request Feb 2, 2022
@Callisto13
Revert "Use bot token for image push (#127)"
44ab05a 
This reverts commit e996e5f.
Callisto13 added a commit that referenced this pull request Feb 2, 2022
@Callisto13
Revert "Use bot token for image push (#127)" (#129)
c20ee30 
This reverts commit e996e5f.
@Callisto13 Callisto13 mentioned this pull request Feb 25, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yitsushi yitsushi yitsushi approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use generic PAT for docker action secret
2 participants
@Callisto13 @yitsushi