Skip to content

Commit

Permalink
Update the 'bump firecracker' issue template (#671)
Browse files Browse the repository at this point in the history
Also update the maintainers.
  • Loading branch information
Callisto13 authored Mar 13, 2023
1 parent 119029a commit c2da518
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/fork.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
title: 'Bump firecracker version to ${{ env.NEW_VERSION }}'
pinned: false
close-previous: true
assignees: "Callisto13, richardcase"
assignees: "Callisto13, yitsushi, Skarlso"
rotate-assignees: true
body: |-
This is an automatically generated Issue to release a new version of
Expand All @@ -43,17 +43,18 @@ jobs:
branch published.
This Issue is to track those manual steps.
**Note that for now we are mirroring firecracker's releases of both v1.1.x and v1.2.x versions**.
**Note that for now we are mirroring firecracker's releases of v1.1.x, v1.2.x and v1.3.x versions**.
To complete work on this Issue:
- [ ] Clone [our fork](https://github.com/weaveworks/firecracker) (if you do not have it already).
- [ ] Add the upstream as a remote: `git add remote up https://github.com/firecracker-microvm/firecracker`
- [ ] Fetch all branches and tags: `git fetch && git fetch --tags`
- [ ] Check out to the relevant `macvtap` version branch. `feature/macvtap` for a new `v1.2.x` release, `feature/macvtapv11x` for a new `v1.1.x` release.
- [ ] Update the feature branch. `git rebase firecracker-v1.2` for a `v1.2.x` release `git rebase firecracker-v1.1` for a `v1.1.x` release.
- [ ] Resolve any merge conflicts if necessary.
- [ ] Update the feature branch. `git rebase firecracker-v1.3` for a `v1.3.x` release `git rebase firecracker-v1.2` for a `v1.2.x` release, etc. etc.
- [ ] Resolve any merge conflicts if necessary. (There will be merge conflicts.)
- [ ] Add any code if necessary. (This will gradually become more necessary, because the older this feature branch gets, the more the code around it upstream will change.)
- [ ] Make sure it builds. (`tools/devtool build`)
- [ ] Push the updated firecracker 'feature/macvtap' (or `firecracker/macvtapv11x`) fork branch.
- [ ] Push the updated firecracker 'feature/macvtap' (or `firecracker/macvtapv12`, etc) fork branch.
- [ ] Create a new tag on the updated firecracker fork branch: `git tag -s ${{ env.NEW_VERSION}}-macvtap -m ${{ env.NEW_VERSION }}-macvtap`.
- [ ] Push the tag to the fork: `git push <remote> ${{ env.NEW_VERSION }}-macvtap` (A new [release](https://github.com/weaveworks/firecracker/releases) will be created.)
- [ ] In this repo, trigger the `nightly_e2e` workflow
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr_type.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ jobs:
steps:
- uses: docker://agilepathway/pull-request-label-checker:latest
with:
one_of: kind/bug,kind/documentation,kind/feature,kind/regression,kind/refactor,kind/cleanup
repo_token: ${{ secrets.GITHUB_TOKEN }}
one_of: kind/bug,kind/documentation,kind/feature,kind/regression,kind/refactor,kind/cleanup,kind/chore
repo_token: ${{ secrets.GITHUB_TOKEN }}
1 change: 1 addition & 0 deletions MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ Richard Case <richard@weave.works> (github: @richardcase)
Claudia Beresford <claudia@weave.works> (github: @Callisto13)
Josh Michielsen <josh.michielsen@weave.works> (github: @jmickey)
Balazs Nadasdi <balazs@weave.works> (github: @yitsushi)
Gergely Bräutigam <gergely@weave.works> (github: @Skarlso)

0 comments on commit c2da518

Please sign in to comment.