Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS support to the gRPC Server #243

Closed
richardcase opened this issue Nov 10, 2021 · 2 comments · Fixed by #464
Closed

Add TLS support to the gRPC Server #243

richardcase opened this issue Nov 10, 2021 · 2 comments · Fixed by #464
Assignees
@richardcase @Callisto13
Labels
area/api Indicates an issue or PR relates to the APIs kind/feature New feature or request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@richardcase
Copy link
Member

Describe the solution you'd like:

Add options to flintlock to enable TLS for the grpc server (i.e. flags required for certs). We should still support an insecure option for dev purposes.

It would also be good to expose an option to turn on mutual verification of certs (i.e. tls.RequireAndVerifyClientCert)

In addition to the code changes we will need to update the e2e and docs.

Why do you want this feature:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
@richardcase richardcase added the kind/feature New feature or request label Nov 10, 2021
@richardcase richardcase added area/api Indicates an issue or PR relates to the APIs priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 17, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2022
@richardcase
Copy link
Member Author

This is still required

@Callisto13 Callisto13 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2022
@richardcase richardcase mentioned this issue Jun 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardcase richardcase

@Callisto13 Callisto13

Labels
area/api Indicates an issue or PR relates to the APIs kind/feature New feature or request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add (m)TLS Callisto13/flintlock
2 participants
@richardcase @Callisto13