Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource cleanup ADR #90

Open
richardcase opened this issue Sep 15, 2021 · 11 comments
Open

Resource cleanup ADR #90

richardcase opened this issue Sep 15, 2021 · 11 comments
Labels
adr-required Indicates that the issue or PR contains a decision that needs to be documented in a ADR area/reconciliation Indicates an issue or PR related to reconciliation kind/documentation Documentation only lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@richardcase
Copy link
Member

richardcase commented Sep 15, 2021 •
edited
Loading

We need to decide how we handle unused images, network interfaces.

When a microvm is deleted the snapshots will be deleted. This may leave a container image unused. What should we do with these unused images? A couple of options:

  1. Do nothing
  2. Delete them after X days
  3. Delete them as soon as they become unused.
@richardcase
Copy link
Member Author

With the delete being implemented in #144 having unused images is more likely.

@richardcase richardcase added adr-required Indicates that the issue or PR contains a decision that needs to be documented in a ADR area/reconciliation Indicates an issue or PR related to reconciliation kind/documentation Documentation only labels Oct 19, 2021
@yitsushi
Copy link
Contributor

yitsushi commented Oct 19, 2021 •
edited
Loading

I think creating a command like flintlock cleanup, we can add flags --no-images, --no-snapshots, and --no-something-else and let Ops set up how and when the command is executed. That way they can hook up in a cronjob, or ansible/puppet run,or basically anything they want. The main benefit from the ops side, they can easily enable, disable, or change when and what to clean up. Like do cleanup on x1, y1, and z1 daily, do x2 and y2 right after backup is done, and run x3 on every Monday midnight.

@richardcase
Copy link
Member Author

I like the idea of providing the command as well and leaving it up to the user to schedule its execution.

@richardcase richardcase changed the title Image garbage collection ADR Resource cleanup ADR Oct 27, 2021
@richardcase
Copy link
Member Author

Another option is a maintenance api

@richardcase richardcase added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Oct 27, 2021
@yitsushi yitsushi mentioned this issue Nov 9, 2021
Merged
3 tasks
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 27, 2021
@yitsushi yitsushi mentioned this issue Feb 3, 2022
Open
@LutzLange
Copy link

How about an option in the capi object that selects how cleanup as handled? This could end up in the miroVM details and thus mark how quickly cleanup should happen.

@yitsushi
Copy link
Contributor

I think the issue with the cleanup in the microvm detail, we need cleanup from leftovers, things we couldn't/didn't delete after vm was deleted, like a snapshot. At that point, we don't have the vmspec anymore only leftover garbage on the system. So it's more like a "garbage collector" rather than a "clean up".

(or i misunderstood the microvm details part)

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 23, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2023
@yitsushi
Copy link
Contributor

Still valid.

@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because it has been stalled for 365 days with no activity.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 19, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Closed in Liquid Metal Roadmap - Public May 19, 2024
@richardcase richardcase reopened this Jul 10, 2024
@richardcase richardcase removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jul 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This issue is stale because it has been open 180 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
adr-required Indicates that the issue or PR contains a decision that needs to be documented in a ADR area/reconciliation Indicates an issue or PR related to reconciliation kind/documentation Documentation only lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
No open projects
Liquid Metal Roadmap - Public
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yitsushi @richardcase @LutzLange