Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate dependencies and middlewares in shadow-cljs.edn #140

Closed
liquidz opened this issue Aug 23, 2019 · 4 comments
Closed

Validate dependencies and middlewares in shadow-cljs.edn #140

liquidz opened this issue Aug 23, 2019 · 4 comments

Comments

@liquidz
Copy link
Owner

liquidz commented Aug 23, 2019

Branched by #135 (comment)
@liquidz liquidz mentioned this issue Aug 23, 2019
Closed
liquidz added a commit that referenced this issue Aug 27, 2019
@liquidz
Add clj/load_files/shadow_cljs.clj #140
6aeb77e
liquidz added a commit that referenced this issue Aug 27, 2019
@liquidz
Update to check shadow-cljs.edn #140
a2f524b
liquidz added a commit that referenced this issue Aug 27, 2019
@liquidz
Add clj/load_files/shadow_cljs.clj #140
7ad4225
liquidz added a commit that referenced this issue Aug 27, 2019
@liquidz
Update to check shadow-cljs.edn #140
b1ee188
@liquidz
Copy link
Owner Author

liquidz commented Aug 27, 2019

@knubie I added shadow-cljs.edn validation on starting cljs repl via #143 !

@liquidz liquidz closed this as completed Aug 27, 2019
@frankitox
Copy link

Just something to keep in mind but you can have false positives of this warning if you use shadow-cljs with other tool. For example, if you use deps.edn to specify the dependencies. Because the code only searches for the deps in shadow-cljs.edn.

@liquidz
Copy link
Owner Author

liquidz commented May 22, 2020

@frankitox It's good to know. Thanks a lot!

Could you create a new issue?

@frankitox
Copy link

Yes, sure. I'll create an issue with more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liquidz @frankitox