Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script does not check for write access to /proc #542

Open
Somebodyisnobody opened this issue Jul 7, 2024 · 3 comments
Open

Install script does not check for write access to /proc #542

Somebodyisnobody opened this issue Jul 7, 2024 · 3 comments
Labels

Comments

@Somebodyisnobody
Copy link

Describe the bug
Install script will fail on systemctl restart freeradius.service in the function freeradius_enable_restart() if wirte access to /proc is denied.

To Reproduce

  • Deny write access to procfs
  • Run install script

Expected behavior
The script should check wirte access before to make it more resilient. Just executing the script again after giving write access to /proc will fail because the directory /var/www/daloradius already exists and the first execution of the script leavs the installation in an unfinished state.

Screenshots
/

Desktop (please complete the following information):

  • OS: Debian 12
  • Your Browser: -
  • daloRADIUS Version: curent master 3d6149d
  • FreeRADIUS Version: 3

Additional context
Add any other context about the problem here.

I am using a Proxmox Virtual Environment server (PVE) with this script running in a container where the nested feature was turned off which denied access to /proc and /sys.

@filippolauria
Copy link
Collaborator

@Somebodyisnobody at the moment, the installation script is not supported on Debian LXC containers that do not have the nesting feature enable on a Proxmox virtualization environment.

@Somebodyisnobody
Copy link
Author

That's no problem. My intention was only to give you feedback to have the chance improving the installation script. I fixed it for me and hopefully my problem description and solution will help others that have the same issue until you had time to enhance the script if you want.

@filippolauria
Copy link
Collaborator

Thank you for your feedback. If you want to push your fixes to this repository, it is actually quite simple. Have a look at the first contributions how to 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants